Design: namespace selection by label selector #9223
+331
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
changed the title
kaovilai
force-pushed
the
design-7492
branch
from
de64ea6 to
aa572fe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9223 +/- ##
=======================================
Coverage 59.64% 59.64%
=======================================
Files 382 382
Lines 43960 43960
=======================================
Hits 26221 26221
Misses 16193 16193
Partials 1546 1546 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This design proposal addresses issue vmware-tanzu#7492 by modifying Velero's backup behavior to include all resources from namespaces selected by labelSelector or orLabelSelectors, equivalent to explicitly listing them in includedNamespaces. Key design decisions: - Modify existing LabelSelector behavior (breaking change) - Precedence: (includedNamespaces ∪ labelSelector ∪ orLabelSelectors) - excludedNamespaces - Support full Kubernetes label selector syntax - Enhanced logging for namespace selection transparency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
Remove multi-phase approach as requested - combine all implementation work into a single comprehensive plan with 6-week timeline. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
design-7492
branch
from
57a6266 to
2eeba84
Compare
Clean up markdown formatting issues detected by linter including: - Add proper blank lines around lists and headings - Add trailing newline at end of file - Improve code block formatting consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
design-7492
branch
from
2eeba84 to
3ed43fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design proposal addresses issue #7492 by modifying Velero's backup
behavior to include all resources from namespaces selected by labelSelector
or orLabelSelectors, equivalent to explicitly listing them in
includedNamespaces.
Key design decisions:
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Design for #7492
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.