Skip to content

Conversation

@blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Nov 26, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #9033

Please indicate you've done the following:

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.26%. Comparing base (554b04e) to head (0964365).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9431      +/-   ##
==========================================
+ Coverage   60.23%   60.26%   +0.02%     
==========================================
  Files         386      386              
  Lines       35937    35908      -29     
==========================================
- Hits        21648    21641       -7     
+ Misses      12715    12697      -18     
+ Partials     1574     1570       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Remove VolumeSnapshotClass from backup sync process.

Signed-off-by: Xun Jiang <[email protected]>
Copy link
Collaborator

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider documenting

"When restoring to a different cluster, any VolumeSnapshotClass-specific parameters (e.g., AWS EBS Fast Snapshot Restore, GCP storage-locations) from the source cluster will not be preserved. Ensure your destination cluster's default VolumeSnapshotClass is configured appropriately for your workload requirements."

@blackpiglet
Copy link
Contributor Author

blackpiglet commented Dec 12, 2025

Consider documenting

"When restoring to a different cluster, any VolumeSnapshotClass-specific parameters (e.g., AWS EBS Fast Snapshot Restore, GCP storage-locations) from the source cluster will not be preserved. Ensure your destination cluster's default VolumeSnapshotClass is configured appropriately for your workload requirements."

Restoring to a new cluster doesn't require a VolumeSnapshotClass to work.
Because the VolumeSnapshot and VolumeSnapshotContent are created from VolumeSnapshotClass, they already have the VolumeSnapshotClass's parameter in them, and Velero only needs to restore the backed-up VolumeSnapshot and VolumeSnapshotContent; no dynamic creation is required.

As a result, the restore can work even without any VolumeSnapshotClass existing in the cluster.

@blackpiglet blackpiglet merged commit add66ea into main Dec 12, 2025
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check whether it's possible to remove VolumeSnapshotClass from the CSI B/R

4 participants