-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove VolumeSnapshotClass from CSI B/R process. #9431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4fb0825 to
800ab9c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9431 +/- ##
==========================================
+ Coverage 60.23% 60.26% +0.02%
==========================================
Files 386 386
Lines 35937 35908 -29
==========================================
- Hits 21648 21641 -7
+ Misses 12715 12697 -18
+ Partials 1574 1570 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
42d74de to
7a43572
Compare
Remove VolumeSnapshotClass from backup sync process. Signed-off-by: Xun Jiang <[email protected]>
7a43572 to
0964365
Compare
kaovilai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider documenting
"When restoring to a different cluster, any VolumeSnapshotClass-specific parameters (e.g., AWS EBS Fast Snapshot Restore, GCP storage-locations) from the source cluster will not be preserved. Ensure your destination cluster's default VolumeSnapshotClass is configured appropriately for your workload requirements."
Restoring to a new cluster doesn't require a VolumeSnapshotClass to work. As a result, the restore can work even without any VolumeSnapshotClass existing in the cluster. |
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #9033
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.