Fix plugin init container names exceeding DNS-1123 limit #9445
+184
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpryc
force-pushed
the
fix-initcontainer-name
branch
from
a8de2ed to
1092b7c
Compare
Ensure plugin init container names satisfy DNS-1123 label constraints (max 63 chars). Long names are truncated with an 8-char hash suffix to maintain uniqueness. Fixes: vmware-tanzu#9444 Signed-off-by: Michal Pryc <[email protected]>
mpryc
force-pushed
the
fix-initcontainer-name
branch
from
1092b7c to
11cf772
Compare
kaovilai
approved these changes
Dec 8, 2025
shubham-pampattiwar
approved these changes
Dec 8, 2025
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9445 +/- ##
=======================================
Coverage 60.13% 60.13%
=======================================
Files 386 386
Lines 35865 35865
=======================================
Hits 21567 21567
Misses 12717 12717
Partials 1581 1581 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure plugin init container names satisfy DNS-1123 label constraints (max 63 chars). Long names are truncated with an 8-char hash suffix to maintain uniqueness.
Fixes: #9444