Skip to content
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
fcdc0f5
initial test
tinuademargaret Apr 8, 2025
d463293
initial profiling
Apr 8, 2025
4b91919
initial fusion test
tinuademargaret Apr 8, 2025
2d8e0bc
fixes
tinuademargaret Apr 8, 2025
3ff92ac
fix lr scheduler
tinuademargaret Apr 10, 2025
f991417
debugging fusion with gradient accumulation
tinuademargaret Apr 11, 2025
50c8db3
use flag
tinuademargaret Apr 17, 2025
7d263e2
fixes
tinuademargaret Apr 21, 2025
b632651
tests
tinuademargaret Apr 23, 2025
81930ea
test flat params
tinuademargaret Apr 23, 2025
74e09c7
update params to flat params
tinuademargaret Apr 23, 2025
281fc87
sft optimiser fuse
tinuademargaret Apr 23, 2025
bf2a0a7
fix batch size
tinuademargaret Apr 23, 2025
3a5d7e9
fix normalise bsz
tinuademargaret Apr 23, 2025
c6a39b7
test ppo config
tinuademargaret Apr 23, 2025
ac0d426
fix config
tinuademargaret Apr 24, 2025
20af206
add bwd hook to actor worker
tinuademargaret Apr 24, 2025
55c35ef
update sft trainer
tinuademargaret Apr 24, 2025
e7b7acc
fixes
tinuademargaret Apr 24, 2025
d827d11
update critic
tinuademargaret Apr 25, 2025
22565e1
fix
tinuademargaret Apr 25, 2025
f2f94ef
delete prev memory
tinuademargaret Apr 28, 2025
ccefe19
remove prev scheduler
tinuademargaret Apr 28, 2025
70a1859
Merge branch 'main' into feat-optimiser-fuse
tinuademargaret Apr 28, 2025
2c43fa5
revert changes for rl workers
tinuademargaret May 7, 2025
ccd3658
update sft config
tinuademargaret May 7, 2025
a098aa0
clean up
tinuademargaret May 8, 2025
7df87b6
Merge branch 'main' into feat-optimiser-fuse
tinuademargaret May 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update params to flat params
  • Loading branch information
tinuademargaret committed Apr 23, 2025
commit 74e09c79b32fac5203738ef7c29fc24f46e39ec0
3 changes: 1 addition & 2 deletions verl/trainer/fsdp_sft_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,7 @@ def _build_model_optimizer(self):


self.optimizer = None
#
flat_params = flat_params = [p for p in self.fsdp_model.parameters() if isinstance(p, FlatParameter)]
flat_params = [p for p in self.fsdp_model.parameters() if p.requires_grad]
if self.optim_bwd_hook:
_apply_optimizer_in_backward(
optim.AdamW,
Expand Down