[rollout] fix: add missing extra_reward_info to AgentLoopOuput #3194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to add extra_reward_info to the AgentLoopOutput for metrics calculation. The changes are propagated through the agent loop, reward managers, and tests. While the overall direction is correct, I've found two critical issues in verl/experimental/agent_loop/agent_loop.py that could lead to runtime errors or incorrect behavior due to improper handling of aggregated data from multiple sources. My review provides specific fixes for these issues.
vermouth1992
approved these changes
Aug 25, 2025
PopSoda2002
pushed a commit
to PopSoda2002/verl
that referenced
this pull request
Aug 26, 2025
…ngine#3194) ### What does this PR do? Fix volcengine#3055, add missing `extra_reward_info` to AgentLoopOuput, which is needed by metrics calculation.
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Aug 27, 2025
…ngine#3194) ### What does this PR do? Fix volcengine#3055, add missing `extra_reward_info` to AgentLoopOuput, which is needed by metrics calculation.
cczitong123
pushed a commit
to cczitong123/verl
that referenced
this pull request
Sep 5, 2025
…ngine#3194) ### What does this PR do? Fix volcengine#3055, add missing `extra_reward_info` to AgentLoopOuput, which is needed by metrics calculation.
DDVD233
pushed a commit
to DDVD233/mirl
that referenced
this pull request
Sep 5, 2025
…ngine#3194) ### What does this PR do? Fix volcengine#3055, add missing `extra_reward_info` to AgentLoopOuput, which is needed by metrics calculation.
WncFht
pushed a commit
to WncFht/verl
that referenced
this pull request
Oct 10, 2025
…ngine#3194) ### What does this PR do? Fix volcengine#3055, add missing `extra_reward_info` to AgentLoopOuput, which is needed by metrics calculation.
techkang
pushed a commit
to techkang/verl
that referenced
this pull request
Oct 31, 2025
…ngine#3194) ### What does this PR do? Fix volcengine#3055, add missing `extra_reward_info` to AgentLoopOuput, which is needed by metrics calculation.
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
…ngine#3194) ### What does this PR do? Fix volcengine#3055, add missing `extra_reward_info` to AgentLoopOuput, which is needed by metrics calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #3055, add missing
extra_reward_infoto AgentLoopOuput, which is needed by metrics calculation.