Refactor send_input to handle single line comments and lingering output #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlafreniere
approved these changes
Nov 15, 2019
ellbosch
reviewed
Nov 18, 2019
ellbosch
reviewed
Nov 18, 2019
ellbosch
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/azuredatastudio#8277
Fixes microsoft/azuredatastudio#7999
There are a couple of things going on in this change. Originally, I intended to fix the above issues with end of line comments by adding a newline to the end of the input text. That solved the comment problem, but then I started seeing issues with cell execution always returning the last result run. Looks like we continually append text to self.output (even after a command "completes"), which messes up the string parsing to get cell outputs later. My solution here was to clear self.output before running a command.
Since we're modifying self.output in a multithreaded environment, I also decided to combine the input and output functions and add some locking for good measure.
Any ideas for potential edge case tests here would be appreciated.