Skip to content

Conversation

@Dan33l
Copy link
Member

@Dan33l Dan33l commented Jul 18, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues


**Implemented enhancements:**

- add openvpn::deploy::\(export/client\) [\#261](https://github.com/voxpupuli/puppet-openvpn/pull/261) ([to-kn](https://github.com/to-kn))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this moved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not found why.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your idea is the good one with an older version github_changelog_generator (1.15.0.pre.rc) the CHANGELOG is correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to find out exactly which commit broke it and why and open an issue. Meanwhile... do you just want to use a version that works or manually fix up this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The moved item is not moved all the times.
Without changing the version of GCG, running several times the rake task bundle exec rake changelog does not gives always same result. Some times the order is not the good one.

@Dan33l Dan33l force-pushed the release_8.2.0 branch 2 times, most recently from d035e37 to 5a63c67 Compare July 19, 2019 10:13
@Dan33l Dan33l merged commit 3ba1b99 into voxpupuli:master Jul 19, 2019
@Dan33l Dan33l deleted the release_8.2.0 branch July 19, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants