Use $real_pkgname for pip uninstall command#607
Merged
bastelfreak merged 7 commits intovoxpupuli:masterfrom Apr 28, 2021
Merged
Use $real_pkgname for pip uninstall command#607bastelfreak merged 7 commits intovoxpupuli:masterfrom
bastelfreak merged 7 commits intovoxpupuli:masterfrom
Conversation
kenyon
approved these changes
Apr 26, 2021
Member
kenyon
left a comment
kenyon
left a comment
There was a problem hiding this comment.
Would be good to also add a test for this so that it doesn't break again.
Contributor
Author
|
I've added the test, should be enough. |
bastelfreak
reviewed
Apr 26, 2021
bastelfreak
reviewed
Apr 27, 2021
Contributor
Author
|
I guess system wide pip path may differ on different OSes. I'll fix the acceptance tests to run pip inside virtualenv. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #606
Pull Request (PR) description
Use $real_pkgname for pip uninstall command
This Pull Request (PR) fixes the following issues
Fixes #606