Enable Hiera syntax check #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Mar 11, 2024
bastelfreak
force-pushed
the
hiera
branch
2 times, most recently
from
18795c1 to
f2a9da7
Compare
zilchms
approved these changes
Mar 12, 2024
bastelfreak
added a commit
to bastelfreak/puppetlabs_spec_helper
that referenced
this pull request
Mar 12, 2024
This is a new option in puppet-syntax 4.1.0: voxpupuli/puppet-syntax#143 It will be enabled in puppet-syntax 5 be default: voxpupuli/puppet-syntax#167
bastelfreak
force-pushed
the
hiera
branch
2 times, most recently
from
7a6883e to
485ad08
Compare
The Hiera key check exists since a long time and I think it makes sense to enable it by default. This is a potential breaking change, so we should probably wait with merging until the next major release. In addition we also enable the checks for Hiera values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check exists since a long time and I think it makes sense to enable it by default. This is a potential breaking change, so we should probably wait with merging until the next major release.