Skip to content

Conversation

@hellofanny
Copy link
Contributor

@hellofanny hellofanny commented Jun 17, 2022

Ported from https://github.com/vtex-sites/nextjs.store/pull/129

What's the purpose of this pull request?

General improvements on Storybook.

How does it work?

  • Displays the Sandbox tab: so we can test viewports and use other addons (Accessibility)
  • Adds project's viewports to help with components' resizes tests
    preview-tab
  • Fixes some console errors:
    - Importing from '@storybook/addon-docs/blocks' is deprecated.
    - Adds OnChange handler to components examples (Checkbox, Radio, Toggle)
    image

How to test it?

  • Check on the preview if Sandbox and Docs tabs are available (except Getting Started, Theming, Fundamentals pages and Changelog)
  • When switching tabs, Sandbox might not be working properly until you reload the page.
    There is a note on the Getting Started's page regarding this issue
    image

References

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#12)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jun 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gatsby-store-storybook ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 1:54PM (UTC)

@hellofanny hellofanny self-assigned this Jun 17, 2022
@hellofanny hellofanny added Features New feature or request Chore General tasks. labels Jun 17, 2022
@hellofanny hellofanny marked this pull request as ready for review June 17, 2022 19:16
@vtex-sites
Copy link

vtex-sites bot commented Jun 17, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-62679bd--gatsby.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 62679bd

@renatamottam renatamottam self-requested a review June 17, 2022 19:19
Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtex-sites
Copy link

vtex-sites bot commented Jun 17, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 62679bd

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@hellofanny hellofanny merged commit 62679bd into main Jun 20, 2022
@hellofanny hellofanny deleted the chore/storybook-improvements branch June 20, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Chore General tasks. Features New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants