generated from vtex-sites/base.store
-
Notifications
You must be signed in to change notification settings - Fork 14
Chore: storybook improvements #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing from '@storybook/addon-docs/blocks' is deprecated. https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#deprecated-scoped-blocks-imports
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-62679bd--gatsby.preview.vtex.app |
renatamottam
approved these changes
Jun 17, 2022
Collaborator
renatamottam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 62679bd
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from https://github.com/vtex-sites/nextjs.store/pull/129
What's the purpose of this pull request?
General improvements on Storybook.
How does it work?
Sandboxtab: so we can test viewports and use other addons (Accessibility)- Importing from '@storybook/addon-docs/blocks' is deprecated.
- Adds
OnChangehandler to components examples (Checkbox,Radio,Toggle)How to test it?
SandboxandDocstabs are available (exceptGetting Started,Theming,Fundamentalspages andChangelog)Sandboxmight not be working properly until you reload the page.There is a note on the Getting Started's page regarding this issue
References
Checklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#12)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation