Skip to content

Fix Style Guide: Base component names example #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NataliaTepluhina merged 1 commit into from
Jan 22, 2020
Merged

Fix Style Guide: Base component names example #2449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Style Guide: Base component names example 
Webpack `require.context` matches file relative path.
For example: `['./BaseXXX.vue', './BaseYYY.vue']`, the path starts with './'
regex `/^Base/` will get empty result.
  • Loading branch information
@hzchirs
hzchirs authored Jan 20, 2020
commit 300dde7bc6602c885bf5572bfb71c5752c60803d
2 changes: 1 addition & 1 deletion src/v2/style-guide/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ Some advantages of this convention:
- Since these components are so frequently used, you may want to simply make them global instead of importing them everywhere. A prefix makes this possible with Webpack:

``` js
var requireComponent = require.context("./src", true, /^Base[A-Z]/)
var requireComponent = require.context("./src", true, /Base[A-Z]\w+\.(vue|js)$/)
requireComponent.keys().forEach(function (fileName) {
var baseComponentConfig = requireComponent(fileName)
baseComponentConfig = baseComponentConfig.default || baseComponentConfig
Expand Down