chore(plugin/nightwatch): bump nightwatch dependency #3388
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
added
PR: Breaking Change
PR: Underlying Tools
and removed
semver: major
labels
Contributor
Author
|
@sodatea you may also want to bump chromedriver for the next major release since it has been bumped a couple major versions. Chrome is at version 74 and this chromedriver expects versions 70-73. |
Member
|
So now chromedriver's major version number is strictly in line with Chrome, whose release cycle is 6 weeks? In that case I think we'll need to hoist the chromedriver dependency to project root. |
haoqunjiang
pushed a commit
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yarn.lock file changes fairly drastically when I run yarn so not committing it in this PR. I was able to run the test and it ran successfully. I also ran this in the context of a new project and everything seems to work well with boilerplate generators.