Skip to content

fix($core): #2627 Dup ID violates HTML5-4 #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bencodezen merged 4 commits into from
Oct 13, 2020
Merged

fix($core): #2627 Dup ID violates HTML5-4 #2650

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34935ca
fix($core): #2627 Dup ID violates HTML5
adico1 Oct 8, 2020
fa3d481
fix($core): #2627 Dup ID violates HTML5-2
adico1 Oct 8, 2020
235a4aa
fix($core): #2627 Dup ID violates HTML5-3
adico1 Oct 8, 2020
56daec7
fix($core): #2627 Dup ID violates HTML5-4
adico1 Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix($core): #2627 Dup ID violates HTML5-4
  • Loading branch information
@adico1
adico1 committed Oct 9, 2020
commit 56daec72207c43cf83ab3a6a811624dfd34c0914
7 changes: 2 additions & 5 deletions packages/@vuepress/core/lib/client/components/OutboundLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
<template>
<span
:title="openInNewWindowTitle"
class="sr-only"
>
<span>
<svg
class="icon outbound"
xmlns="http://www.w3.org/2000/svg"
aria-hidden="true"
role="img"
focusable="false"
x="0px"
y="0px"
Expand All @@ -24,6 +20,7 @@
points="45.7,48.7 51.3,54.3 77.2,28.5 77.2,37.2 85.2,37.2 85.2,14.9 62.8,14.9 62.8,22.9 71.5,22.9"
/>
</svg>
<span class="sr-only">{{ openInNewWindowTitle }}</span>
</span>
</template>

Expand Down
10 changes: 10 additions & 0 deletions packages/@vuepress/theme-default/styles/index.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,16 @@ th, td
.sidebar
top 0

.sr-only
position absolute
width 1px
height 1px
padding 0
margin -1px
overflow hidden
clip rect(0, 0, 0, 0)
white-space nowrap
border-width 0

@media (min-width: ($MQMobile + 1px))
.theme-container.no-sidebar
Expand Down