chore: enable typescript error on unused locals (conventional-changelog#938)

armano2 · web-flow · commit 80d3362da46b · 2020-02-05T10:55:50.000+11:00
* chore: enable typescript error on unused locals

* chore: add more typescript compiler flags
diff --git a/@commitlint/load/src/load.test.ts b/@commitlint/load/src/load.test.ts
@@ -12,7 +12,6 @@ import resolveFrom from 'resolve-from';
 import {fix, git, npm} from '@commitlint/test';
 
 import load from './load';
-import {RuleSeverity} from './types';
 
 const fixBootstrap = (name: string) => fix.bootstrap(name, __dirname);
 const gitBootstrap = (name: string) => git.bootstrap(name, __dirname);
diff --git a/@commitlint/resolve-extends/src/index.test.ts b/@commitlint/resolve-extends/src/index.test.ts
@@ -1,5 +1,4 @@
 import resolveExtends, {ResolveExtendsContext} from '.';
-import resolveGlobal from 'resolve-global';
 
 const id = (id: unknown) => id;
 
diff --git a/@commitlint/resolve-extends/src/index.ts b/@commitlint/resolve-extends/src/index.ts
@@ -94,7 +94,7 @@ function getId(raw: string = '', prefix: string = ''): string {
 	return relative || absolute ? raw : [prefix, raw].filter(String).join('-');
 }
 
-function resolveConfig<T>(
+function resolveConfig(
 	raw: string,
 	context: ResolveExtendsContext = {}
 ): string {
diff --git a/@commitlint/rules/src/body-max-length.ts b/@commitlint/rules/src/body-max-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const bodyMaxLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.body;
diff --git a/@commitlint/rules/src/body-max-line-length.ts b/@commitlint/rules/src/body-max-line-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const bodyMaxLineLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.body;
diff --git a/@commitlint/rules/src/body-min-length.ts b/@commitlint/rules/src/body-min-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const bodyMinLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	if (!parsed.body) {
diff --git a/@commitlint/rules/src/footer-max-length.ts b/@commitlint/rules/src/footer-max-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const footerMaxLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.footer;
diff --git a/@commitlint/rules/src/footer-max-line-length.ts b/@commitlint/rules/src/footer-max-line-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const footerMaxLineLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.footer;
diff --git a/@commitlint/rules/src/footer-min-length.ts b/@commitlint/rules/src/footer-min-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const footerMinLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	if (!parsed.footer) {
diff --git a/@commitlint/rules/src/header-max-length.ts b/@commitlint/rules/src/header-max-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const headerMaxLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	return [
diff --git a/@commitlint/rules/src/header-min-length.ts b/@commitlint/rules/src/header-min-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const headerMinLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	return [
diff --git a/@commitlint/rules/src/scope-max-length.ts b/@commitlint/rules/src/scope-max-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const scopeMaxLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.scope;
diff --git a/@commitlint/rules/src/scope-min-length.ts b/@commitlint/rules/src/scope-min-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const scopeMinLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.scope;
diff --git a/@commitlint/rules/src/subject-max-length.ts b/@commitlint/rules/src/subject-max-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const subjectMaxLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.subject;
diff --git a/@commitlint/rules/src/subject-min-length.ts b/@commitlint/rules/src/subject-min-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const subjectMinLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.subject;
diff --git a/@commitlint/rules/src/type-max-length.ts b/@commitlint/rules/src/type-max-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const typeMaxLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.type;
diff --git a/@commitlint/rules/src/type-min-length.ts b/@commitlint/rules/src/type-min-length.ts
@@ -3,7 +3,7 @@ import {Rule} from './types';
 
 export const typeMinLength: Rule<number> = (
 	parsed,
-	when = undefined,
+	_when = undefined,
 	value = 0
 ) => {
 	const input = parsed.type;
diff --git a/tsconfig.shared.json b/tsconfig.shared.json
@@ -9,6 +9,13 @@
         "module": "commonjs",
         "esModuleInterop": true,
         "allowSyntheticDefaultImports": true,
-        "strict": true
+        "strict": true,
+        "allowUnreachableCode": false,
+        "allowUnusedLabels": false,
+        "noUnusedLocals": true,
+        "noUnusedParameters": true,
+        "forceConsistentCasingInFileNames": true,
+        "keyofStringsOnly": true,
+        "noFallthroughCasesInSwitch": true
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import resolveExtends, {ResolveExtendsContext} from '.';`
`2`		`-import resolveGlobal from 'resolve-global';`
`3`	`2`
`4`	`3`	`const id = (id: unknown) => id;`
`5`	`4`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ function getId(raw: string = '', prefix: string = ''): string {`
`94`	`94`	`return relative \|\| absolute ? raw : [prefix, raw].filter(String).join('-');`
`95`	`95`	`}`
`96`	`96`
`97`		`-function resolveConfig<T>(`
	`97`	`+function resolveConfig(`
`98`	`98`	`raw: string,`
`99`	`99`	`context: ResolveExtendsContext = {}`
`100`	`100`	`): string {`