Skip to content

Conversation

@armano2
Copy link
Contributor

@armano2 armano2 commented Feb 4, 2020

Enable typescript compiler flags for catchign unused locals and unreachable code

i was also thinking about noUnusedParameters but i'm not sure about this one for now

Motivation and Context

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl
Copy link
Contributor

Good call! Let's make our TypeScript config as strict/safe as possible.

Candidates for configuration:

  • noUnusedParameters
  • forceConsistentCasingInFileNames
  • isolatedModules
  • keyofStringsOnly
  • noFallthroughCasesInSwitch

@armano2
Copy link
Contributor Author

armano2 commented Feb 4, 2020

ok all enabled, except isolatedModules as for now its not going to compile due to chalk, and exports in ensure and is-ignored

@marionebl marionebl merged commit 80d3362 into conventional-changelog:master Feb 4, 2020
@armano2 armano2 deleted the no-unused-locals branch February 4, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants