Skip to content

Conversation

@vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Dec 31, 2022

Description

#334 actually introduced a major bug... It's totally my bad 🙈

        storage = storage.replace(
            advantages=advantages,
            returns=storage.advantages + storage.values,
        )

should have been the following because storage.advantages has zero values.

        storage = storage.replace(
            advantages=advantages,
            returns=advantages + storage.values,
        )

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

@vwxyzjn vwxyzjn requested a review from 51616 December 31, 2022 22:58
@vercel
Copy link

vercel bot commented Dec 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cleanrl ✅ Ready (Inspect) Visit Preview Dec 31, 2022 at 10:58PM (UTC)

@vwxyzjn vwxyzjn merged commit 95fcdd7 into master Dec 31, 2022
Copy link
Collaborator

@51616 51616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. Btw, did the gae test in #334 run correctly? Seems like the bug is in the test file as well.

@vwxyzjn vwxyzjn mentioned this pull request Jan 1, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants