Skip to content

fix pre-commit #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vwxyzjn merged 1 commit into from
Jan 16, 2023
Merged

fix pre-commit #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cleanrl/dqn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ def linear_schedule(start_e: float, end_e: float, duration: int, t: int):
if global_step % args.target_network_frequency == 0:
for target_network_param, q_network_param in zip(target_network.parameters(), q_network.parameters()):
target_network_param.data.copy_(
args.tau * q_network_param.data + (1. - args.tau) * target_network_param.data)
args.tau * q_network_param.data + (1.0 - args.tau) * target_network_param.data
)

if args.save_model:
model_path = f"runs/{run_name}/{args.exp_name}.cleanrl_model"
Expand Down
3 changes: 2 additions & 1 deletion cleanrl/dqn_atari.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ def linear_schedule(start_e: float, end_e: float, duration: int, t: int):
if global_step % args.target_network_frequency == 0:
for target_network_param, q_network_param in zip(target_network.parameters(), q_network.parameters()):
target_network_param.data.copy_(
args.tau * q_network_param.data + (1. - args.tau) * target_network_param.data)
args.tau * q_network_param.data + (1.0 - args.tau) * target_network_param.data
)

if args.save_model:
model_path = f"runs/{run_name}/{args.exp_name}.cleanrl_model"
Expand Down
4 changes: 3 additions & 1 deletion cleanrl/dqn_atari_jax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,9 @@ def mse_loss(params):

# update target network
if global_step % args.target_network_frequency == 0:
q_state = q_state.replace(target_params=optax.incremental_update(q_state.params, q_state.target_params, args.tau))
q_state = q_state.replace(
target_params=optax.incremental_update(q_state.params, q_state.target_params, args.tau)
)

if args.save_model:
model_path = f"runs/{run_name}/{args.exp_name}.cleanrl_model"
Expand Down
4 changes: 3 additions & 1 deletion cleanrl/dqn_jax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,9 @@ def mse_loss(params):

# update target network
if global_step % args.target_network_frequency == 0:
q_state = q_state.replace(target_params=optax.incremental_update(q_state.params, q_state.target_params, args.tau))
q_state = q_state.replace(
target_params=optax.incremental_update(q_state.params, q_state.target_params, args.tau)
)

if args.save_model:
model_path = f"runs/{run_name}/{args.exp_name}.cleanrl_model"
Expand Down