-
Couldn't load subscription status.
- Fork 420
Open
Labels
questionIssue asking a questionIssue asking a questionregression-testingRelated to AVA regression tests of example pages or AVA framework implementation within repoRelated to AVA regression tests of example pages or AVA framework implementation within repo
Description
Review comments about test merge conflicts in 1356.
We seem to get caught in a loop when trying to remove a test file. PR 1356 originally moved the editor menubar example up one level in the directory structure and renamed it. Jon tried to adjust the tests in the same PR, but doing so either resulted in a state where there were merge conflicts or a state where tests failed.
Our current work around is:
- Instead of move/rename of the example, PR 1356 now creates a new version, leaving existing the same.
- After we merge the new, make a PR to delete the old.
Is this how it must be done to get through CI? When PR 1356 was first created, it did a move/rename and the tests were passing and there were no merge conflicts. So, it does seem like has something has changed, but we don't know what.
Metadata
Metadata
Assignees
Labels
questionIssue asking a questionIssue asking a questionregression-testingRelated to AVA regression tests of example pages or AVA framework implementation within repoRelated to AVA regression tests of example pages or AVA framework implementation within repo