Skip to content

Sources "Read This First, No ARIA is better than Bad ARIA" banner from APG #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howard-e merged 16 commits into from
Sep 2, 2025
Merged

Sources "Read This First, No ARIA is better than Bad ARIA" banner from APG #422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1828482
Source read-this-first and other template content directly from w3c/a…
howard-e Jul 28, 2025
a24ecb3
Update styles
howard-e Jul 28, 2025
ee92e6f
Add files after pre-build
howard-e Jul 28, 2025
91bcfa3
Update transform for updating read-this-first.js script as needed
howard-e Jul 30, 2025
03f973b
fix transformOtherAsset spacing
howard-e Jul 30, 2025
639cab9
Testing image with another path
howard-e Jul 30, 2025
0ce295e
Update transformOtherAsset to account for read-me-first url
howard-e Jul 30, 2025
b44f627
Update built files
howard-e Jul 30, 2025
6d38a4c
Update built files
howard-e Jul 30, 2025
56686f8
Update transformTemplate.js
howard-e Jul 30, 2025
20f7d0d
Update built files
howard-e Jul 30, 2025
785e975
Merge branch 'main' into read-this-first-at-source
howard-e Aug 19, 2025
45b17ca
Fix merge conflicts
howard-e Aug 19, 2025
c4ac250
Revert .gitmodules
howard-e Sep 2, 2025
7aa1329
Merge branch 'main' into read-this-first-at-source
howard-e Sep 2, 2025
431cdb8
Update following APG merge
howard-e Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update transformOtherAsset to account for read-me-first url
  • Loading branch information
@howard-e
howard-e committed Jul 30, 2025
commit 0ce295eb608f07c3633fa15d2d987f5753cc0d8b
2 changes: 2 additions & 0 deletions content-assets/wai-aria-practices/shared/js/read-this-first.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@
removeImageIfNeeded(bannerElement, config);
const img = bannerElement.querySelector('img'); // Line edited by pre-build script
if (img) img.setAttribute('src', `${basePath}../../content-images/wai-aria-practices/images/read-this-first.svg`); // Line edited by pre-build script
const a = bannerElement.querySelector('a'); // Line edited by pre-build script
if (a) a.setAttribute('href', `${basePath}../../ARIA/apg/practices/read-me-first/`); // Line edited by pre-build script

// Insert the banner after h1
h1.parentNode.insertBefore(bannerElement, h1.nextSibling);
Expand Down
4 changes: 3 additions & 1 deletion scripts/pre-build/library/transformOtherAsset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ const transformAsset = async (sourcePath, sourceContents) => {
"removeImageIfNeeded(bannerElement, config);",
"removeImageIfNeeded(bannerElement, config);\n" +
" const img = bannerElement.querySelector('img'); // Line edited by pre-build script\n" +
" if (img) img.setAttribute('src', `${basePath}../../content-images/wai-aria-practices/images/read-this-first.svg`); // Line edited by pre-build script"
" if (img) img.setAttribute('src', `${basePath}../../content-images/wai-aria-practices/images/read-this-first.svg`); // Line edited by pre-build script\n" +
" const a = bannerElement.querySelector('a'); // Line edited by pre-build script\n" +
" if (a) a.setAttribute('href', `${basePath}../../ARIA/apg/practices/read-me-first/`); // Line edited by pre-build script"
)
}
return sourceContents;
Expand Down