Reintroduce alg JWK field for Ed25519 keys
#401
Conversation
|
Thanks !
I wouldn't say that is a blocker, but it definitively doesn't help to support removing the experimental runtime flag. So the sooner we can address the issue, the better. |
twiss
left a comment
twiss
left a comment
There was a problem hiding this comment.
Thanks! LGTM. If you have time, could you also make a corresponding PR to https://github.com/WICG/webcrypto-secure-curves, to keep them in sync? (Perhaps we should remove Ed25519 from there, but Ed448 also needs the same change, I'm guessing.) Otherwise I can also do it 😊
|
I'm happy to do a PR https://github.com/WICG/webcrypto-secure-curves removing Curve25519 and separately updating Ed448 with "alg" per this PR |
twiss
changed the title
alg JWK field for Ed25519 keys
SHA: e3459a5 Reason: push, by twiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Shouldn't the PR#42333 to the corresponding tests in the WPT repository be reverted then ? Or at least, write again the correct test cases for the new behavior. |
I'm working on that just now. |
Great ! Thank you very much |
The PR#401 [1] changed the spec to accept either "EdDSA" (current) or "Ed25519" in the JWK import operation and just "Ed25519" in the export operation. The PR#51198 [2] has updated the corresponding tests in the WPT repository. [1] w3c/webcrypto#401 [2] web-platform-tests/wpt#51198 Bug: 402138569 Change-Id: I4ec52a9314bf9fa52c861549c5e4e47f610ecee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6339929 Commit-Queue: Javier Fernandez <[email protected]> Reviewed-by: David Benjamin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1441790}
3 participants
With https://datatracker.ietf.org/doc/draft-ietf-jose-fully-specified-algorithms/ submitted to IESG for Publication we can add the new "alg" to the Ed25519 JWK export while accepting both old and new in JWK import.
I don't think this is strictly necessary but I'm opening this here as an option in hopes that it will strike at least one of the objections raised prior by @davidben that (I think?) continues to block the unflagging of Ed25519 in Chromium.
Refs WICG/webcrypto-secure-curves#24
Refs #362 (comment)
Refs https://issues.chromium.org/issues/40074061
Preview | Diff