cleanups to docs for SPARK-15784 #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbradley
commented
Apr 3, 2018
| */ | ||
| @Since("2.3.0") | ||
| val idCol = new Param[String](this, "id", "column name for ids.") | ||
| val idCol = new Param[String](this, "idCol", "Name of the input column for vertex IDs.") |
Author
There was a problem hiding this comment.
The 2nd arg here should match the Param name exactly
jkbradley
commented
Apr 3, 2018
| * Param for the column name for neighbors required by PowerIterationClustering.transform(). | ||
| * Default: "neighbor" | ||
| * Param for the name of the input column for neighbors in the adjacency list representation. | ||
| * Default: "neighbors" |
Author
There was a problem hiding this comment.
I made this plural since each row holds multiple neighbors (not 1 neighbor)
Author
There was a problem hiding this comment.
I updated the Param, getter & setter accordingly
jkbradley
commented
Apr 3, 2018
| "The length of neighbor list must be equal to the the length of the weight list.") | ||
| nbr.toArray.toIterator.zip(weight.toArray.toIterator) | ||
| .map(x => (id, x._1.toLong, x._2))} | ||
| require(nbr.size == weight.size, |
Author
There was a problem hiding this comment.
needed indentation fix to match scala style guide
jkbradley
commented
Apr 3, 2018
| def generatePICData(spark: SparkSession, r1: Double, r2: Double, | ||
| n1: Int, n2: Int): DataFrame = { | ||
| def generatePICData( | ||
| spark: SparkSession, |
jkbradley
commented
Apr 3, 2018
| val rdd = sc.parallelize(similarities).map { | ||
| case (id: Long, nbr: Array[Long], weight: Array[Double]) => | ||
| TestRow2(id, Vectors.dense(nbr.map(i => i.toDouble)), Vectors.dense(weight))} | ||
| TestRow2(id, Vectors.dense(nbr.map(i => i.toDouble)), Vectors.dense(weight)) |
wangmiao1981
pushed a commit
that referenced
this pull request
Oct 16, 2019
…ver)QueryTestSuite ### What changes were proposed in this pull request? This PR adds 2 changes regarding exception handling in `SQLQueryTestSuite` and `ThriftServerQueryTestSuite` - fixes an expected output sorting issue in `ThriftServerQueryTestSuite` as if there is an exception then there is no need for sort - introduces common exception handling in those 2 suites with a new `handleExceptions` method ### Why are the changes needed? Currently `ThriftServerQueryTestSuite` passes on master, but it fails on one of my PRs (apache#23531) with this error (https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111651/testReport/org.apache.spark.sql.hive.thriftserver/ThriftServerQueryTestSuite/sql_3/): ``` org.scalatest.exceptions.TestFailedException: Expected " [Recursion level limit 100 reached but query has not exhausted, try increasing spark.sql.cte.recursion.level.limit org.apache.spark.SparkException] ", but got " [org.apache.spark.SparkException Recursion level limit 100 reached but query has not exhausted, try increasing spark.sql.cte.recursion.level.limit] " Result did not match for query #4 WITH RECURSIVE r(level) AS ( VALUES (0) UNION ALL SELECT level + 1 FROM r ) SELECT * FROM r ``` The unexpected reversed order of expected output (error message comes first, then the exception class) is due to this line: https://github.com/apache/spark/pull/26028/files#diff-b3ea3021602a88056e52bf83d8782de8L146. It should not sort the expected output if there was an error during execution. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing UTs. Closes apache#26028 from peter-toth/SPARK-29359-better-exception-handling. Authored-by: Peter Toth <[email protected]> Signed-off-by: Yuming Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for your PR here apache#15770 to make it easier to show my feedback around docs. Please check and merge/edit as needed. Thanks!
Most of these changes are expanding/clarifying docstrings. I'll comment on the other changes.