feat: update parameter names in recognize/synthesize streams to be lower camel case #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpopp07 the changes look good. Did you run all the examples in the example folder? you can run them locally and then check each one of them to make sure they work |
|
@germanattanasio No I have not - good call. I'll update those today. |
dpopp07
force-pushed
the
update-parameter-names
branch
from
729e8ab to
e361eb9
Compare
|
While updating the examples, I discovered a few mistakes I had made. I pushed the updated code. The examples are all working now. |
|
I think the changes look good. One last request, can you update the CHANGELOG describing the changes to |
|
Yes, good call |
…wer camel case * this is to match the recent changes in the watson node sdk * `access_token` is renamed to `accessToken` in all modules
dpopp07
force-pushed
the
update-parameter-names
branch
from
e361eb9 to
10a3ff1
Compare
|
Changelog updated |
|
🎉 This PR is included in version 0.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
access_tokenis renamed toaccessTokenin all modulesThis certainly presents breaking changes but I don't know that the library is ready for 1.0 so I suppose we're taking advantage of the fact that we're in pre-release.