Fix 7.5/7.5B partial update integer underflow #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
EPD_7in5_V2.c, the functionEPD_7IN5_V2_Display_Parthas this line which tells the EPD the maximum X coordinate of the box it's refreshing:When
x_endis a multiple of 256,x_end%256-1would evaluate to -1, then it would be cast to an unsigned byte. This would lead to an integer underflow. This problem is also present in the Y coordinate, and in the driver code for 7.5B. The_olddrivers, however, do not have this problem.The solution is to change the line to
Thank you for reviewing!