Skip to content

Conversation

@jscheid
Copy link
Collaborator

@jscheid jscheid commented Nov 30, 2016

  • Default crossorigin option to webpack output.crossOriginLoading
  • Warn when crossorigin option is passed
  • Warn when output.crossOriginLoading is not set
  • Error when output.crossOriginLoading is not set and code splitting is
    used

Closes #20

- Default crossorigin option to webpack output.crossOriginLoading
- Warn when crossorigin option is passed
- Warn when output.crossOriginLoading is not set
- Error when output.crossOriginLoading is not set and code splitting is
  used

Closes #20
@XVincentX
Copy link

@waysact Would it be possible to merge this ASAP? I've been making the same mistake and it took me couple of hours before realising that!

@bruno bruno merged commit f562b45 into master Dec 6, 2016
@bruno bruno deleted the use-webpack-output-crossOriginLoading branch December 6, 2016 23:36
@jscheid
Copy link
Collaborator Author

jscheid commented Dec 6, 2016

@XVincentX I'm going to roll a release for this tomorrow.

@jscheid
Copy link
Collaborator Author

jscheid commented Dec 7, 2016

Released in v0.8.0.

@XVincentX
Copy link

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants