cmake: find zlib using PkgConfig#39
Merged
Merged
Conversation
Resolve symlinks to their physical location when using find_package() to find external packages.
FindZlib burns in a path to zlib in the Ptex exported targets, which is undesirable since it make packages unrelocatable. Use pkg-config to find zlib and setup an imported target. Using the imported target handles setting up library and include paths so that we don't have to manually setup zlib beyond mentioning PkgConfig::Ptex_ZLIB in target_link_libraries(). Setup PkgConfig::Ptex_ZLIB in Ptex's exported targets file so that downstream consumers will have PkgConfig::Ptex_ZLIB too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build against zlib using an imported target that can be reused by downstream dependents.