Split font-synthesis into many features in a group #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
foolip
force-pushed
the
split-font-synthesis
branch
from
dcaad4e to
7bda8e1
Compare
ddbeck
reviewed
Apr 26, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
I think this is a sensible approach. This is really fascinating and a place where subject matter expertise is critical in describing features.
I left some questions about auto and none keys.
foolip
force-pushed
the
split-font-synthesis
branch
from
7bda8e1 to
0ba1ca9
Compare
Trying to compute the status of the previous font-synthesis feature proved it to be untenable as a single feature, or as features that pair `font-synthesis: style` with `font-synthesis-style`. Define a bunch of new features, and gently discourage use of the shorthand in the description. See w3c/csswg-drafts#1641 for background.
foolip
force-pushed
the
split-font-synthesis
branch
from
0ba1ca9 to
4d6d19a
Compare
ddbeck
approved these changes
Apr 26, 2024
32 tasks
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Jun 10, 2024
ddbeck
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to compute the status of the previous font-synthesis feature
proved it to be untenable as a single feature, or as features that pair
font-synthesis: stylewithfont-synthesis-style. Define a bunch ofnew features, and gently discourage use of the shorthand in the
description.
See w3c/csswg-drafts#1641 for background.