chore: release-please for db #1577
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a nudge to finish off the db migration automation. as is, this will add release please notes to the PRs and increment the package number. If we do a major change, we'd need to bump the db dep number in the other projects. TODO: - [ ] fork prod db to staging on merge to main - [ ] auto apply migrations to staging - [ ] snapshot prod db on release - [ ] auto apply migrations to prod see: #1482 see: #1275 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <[email protected]>
|
@vasco-santos should we merge this as is just to get release notes and package.json versioning for the db project? api and cron would have to update their dep version in their package.json if there was a major revision, and could elect to bump it deliberately when they want to trigger a release for a db change. |
Yes! we should do this in multiple steps |
| # ./packages/w3/bin.js put ./upload-test-small --api https://api-staging.web3.storage --token ${{ secrets.STAGING_WEB3_TOKEN }} | ||
|
|
||
| release: | ||
| name: Release |
There was a problem hiding this comment.
Shouldn't we check for if: github.event_name == 'push' && github.ref == 'refs/heads/main' like commented above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a nudge to implement the db migration automation.
as is, this will add release please notes to the PRs and increment the package number.
If we do a major change, we'd need to bump the db dep number in the other projects.
TODO:
see: #1482
see: #1275
License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans [email protected]