Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@maektwain
Copy link

@maektwain maektwain commented Mar 30, 2020

As suggested by the #3383

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

Saransh Sharma and others added 2 commits March 30, 2020 14:48
@coveralls
Copy link

coveralls commented Mar 30, 2020

Coverage Status

Coverage remained the same at 88.596% when pulling 2e15ff4 on maektwain:1.x into 2a5c5cb on ethereum:1.x.

Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - there's a small issue with the changelog that still needs to be resolved - otherwise good to go.

@cgewecke cgewecke added 1.x 1.0 related issues Types Incorrect or missing types labels Apr 7, 2020
@cgewecke cgewecke self-requested a review April 9, 2020 19:26
@holgerd77
Copy link
Collaborator

Ok, will merge here.

@holgerd77 holgerd77 merged commit bd9cf48 into web3:1.x Apr 9, 2020
@ryanio ryanio mentioned this pull request Apr 15, 2020
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Types Incorrect or missing types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants