This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Improve check if a provider supports subscriptions #3517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix #3432 where @dmihal outlined some problems where if a given provider has the method
onit is assumed to be capable of handling subscriptions.The first commit adds a failing test validating the issue, and the second commit should resolve it.
In general there is no real way of detecting a provider's capabilities and developing some sort of standard would be of great benefit to the ecosystem. One solution suggested by @nivida that has been well received is a
provider_capabilitiesendpoint.Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run build-alland tested the resulting files fromdistfolder in a browser.CHANGELOG.mdfile in the root folder.