This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fix eth.clearSubscriptions size property de-referencing bug #3531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
thisproperty is not bound correctly at theweb3.ethscope when calling clearSubscriptions:https://github.com/ethereum/web3.js/blob/740a98258ead66c16b1ec12f3f888baee64694b6/packages/web3-eth/src/index.js#L268
...results in
thisreferring toweb3.ethrather than RequestManager when run here:https://github.com/ethereum/web3.js/blob/740a98258ead66c16b1ec12f3f888baee64694b6/packages/web3-core-requestmanager/src/index.js#L269-L274
Fixes #3527
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run build-alland tested the resulting files fromdistfolder in a browser.CHANGELOG.mdfile in the root folder.