Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@ryanio
Copy link
Collaborator

@ryanio ryanio commented May 27, 2020

Description

This PR fixes #3542 by adding typescript bindings for handleRevert.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added Types Incorrect or missing types 1.x 1.0 related issues labels May 27, 2020
@coveralls
Copy link

coveralls commented May 27, 2020

Coverage Status

Coverage remained the same at 89.638% when pulling ac632d5 on issue/3542 into 6cf703a on 1.x.

@cgewecke cgewecke self-requested a review May 27, 2020 18:39
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💯

@ryanio ryanio merged commit ed3323f into 1.x May 28, 2020
@ryanio
Copy link
Collaborator Author

ryanio commented May 28, 2020

thanks!

@ryanio ryanio mentioned this pull request Jul 2, 2020
13 tasks
@mpetrunic mpetrunic deleted the issue/3542 branch October 31, 2023 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Types Incorrect or missing types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handleRevert is missing from TypeScript bindings

4 participants