This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add gnosis/dex E2E target #3562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds gnosis/dex-react as an E2E test target. This repo is a good sanity check that Web3 works with:
Also re-wrote the yarn resolutions helper script so it's generic and will coerce Web3 to the appropriate version for any project which has Web3 in it's sub-dependency tree.
Initial commit added a log line in web3-eth-contract's constructor to verify that CI is actually installing the current Web3 state in the target and its code is getting run. The output should be visible at the links below.
[EDIT - actually you have to click into the job and scroll down the output to see it...]
Fixes #3529
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run build-alland tested the resulting files fromdistfolder in a browser.CHANGELOG.mdfile in the root folder.