Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

format fromBlock param on resubscription #3596

Merged
ryanio merged 3 commits into from
Jun 25, 2020
Merged

format fromBlock param on resubscription #3596

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94d771f
format fromBlock parameter on re-subscription
epiccoolguy Jun 18, 2020
a629577
move use of inputBlockNumberFormatter in order to avoid interfering w…
epiccoolguy Jun 22, 2020
e7c69fb
Revert "move use of inputBlockNumberFormatter in order to avoid inter…
epiccoolguy Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/web3-core-subscriptions/src/subscription.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
var _ = require('underscore');
var errors = require('web3-core-helpers').errors;
var EventEmitter = require('eventemitter3');
var formatters = require('web3-core-helpers').formatters;

function Subscription(options) {
EventEmitter.call(this);
Expand Down Expand Up @@ -227,7 +228,7 @@ Subscription.prototype.subscribe = function() {
// a dropped connection may have resulted in gaps in the logs...
if (this.lastBlock && _.isObject(this.options.params)){
payload.params[1] = this.options.params
payload.params[1].fromBlock = this.lastBlock +1;
payload.params[1].fromBlock = formatters.inputBlockNumberFormatter(this.lastBlock + 1);
}

// if id is there unsubscribe first
Expand Down