Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@cgewecke
Copy link
Collaborator

Description

These characters were accidentally introduced in #3291 and #3137.

They can be made visible in a text editor by setting the file encoding to ISO-8859-1.

Ran a local search and was not able to find any other instances of it.

Fixes #3601

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.

@cgewecke cgewecke added 1.x 1.0 related issues Bug Addressing a bug labels Jun 26, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.16% when pulling 2ac70d5 on issue/3601 into 898322b on 1.x.

Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's sneaky, LGTM, thanks @cgewecke!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Bug Addressing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

utf8 confuses browserify

4 participants