-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Bump web3-providers-ipc oboe version to 2.1.5 #3661
Conversation
So it does not pack 8 MB of test files in its npm package jimhigson/oboe.js#172
|
@maaktweluit nice, thanks for this PR! would you mind adding an entry in the CHANGELOG.md? |
|
@ryanio Anytime! Thanks for the quick reply! Updated changelog.md and checked the box in the description |
GregTheGreek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Ok this looks good! I realized though that we also need to commit the updated package-lock for web3-providers-ipc. @maaktweluit do you mind adding that? |
frankiebee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please commit package-lock for deps bumps
|
@ryanio @frankiebee Yes, will add the |
frankiebee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
So it does not pack 8 MB of test files in its npm package jimhigson/oboe.js#172
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.