Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@fonov
Copy link

@fonov fonov commented Nov 17, 2020

Description

fixes issue when number can only safely store up to 53 bits

#3745

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.

when number can only safely store up to 53 bits

web3#3745
@CLAassistant
Copy link

CLAassistant commented Jan 7, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ spacesailor24
❌ fonov
You have signed the CLA already but the status is still pending? Let us recheck it.

@spacesailor24
Copy link
Contributor

Thank you for opening a PR for this! After discussing this with the team, this would be a breaking change for the library and doesn't make sense to do it in this way for now. To achieve similar functionality without a breaking change, would require an overwriting functionality that will exist using the plugin system we have planned for 1.4.x, but there is not definite timeline for the feature yet

I'm curious to know if this was a one-off issue for you for this transaction, or is this something you've faced multiple times? It's just extremely unusual to set such a high gasLimit

@spacesailor24 spacesailor24 added the Question General discussion questions label Jan 11, 2021
@fonov
Copy link
Author

fonov commented Jan 12, 2021

@spacesailor24 spacesailor24 added On Ice Important but no longer pursued for the near future and removed Question General discussion questions labels Feb 1, 2021
@spacesailor24
Copy link
Contributor

Thank you for the reply, I'm happy to hear you've found a work around. As mentioned above, we most likely won't be merging this any time soon, but we will keep this in mind for the next major version update

@spacesailor24 spacesailor24 added the P1 High severity bugs label Mar 9, 2021
@spacesailor24 spacesailor24 self-assigned this Mar 22, 2021
@lucaspiressimao
Copy link

this could help #3936 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

On Ice Important but no longer pursued for the near future P1 High severity bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants