This repository was archived by the owner on Mar 5, 2025. It is now read-only.
1.x: Fix EIP-1193 provider subscriptions #3864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 496709829
💛 - Coveralls |
Contributor
|
Cool thanks for this will take a look at this! |
Author
|
FYI: I'm receiving reports that using |
Spacesai1or
approved these changes
Jan 20, 2021
Contributor
Spacesai1or
left a comment
Spacesai1or
left a comment
There was a problem hiding this comment.
Installed this patch locally and tested using Firefox and MetaMask v9.0.1
frankiebee
approved these changes
Jan 20, 2021
Contributor
frankiebee
left a comment
frankiebee
left a comment
There was a problem hiding this comment.
purely from a code stand point this looks good!
GregTheGreek
added a commit
that referenced
this pull request
Jan 20, 2021
1.x: Fix EIP-1193 provider subscriptions
GregTheGreek
added a commit
that referenced
this pull request
Jan 21, 2021
1.x: Fix EIP-1193 provider subscriptions
r-czajkowski
added a commit
to threshold-network/keep-core
that referenced
this pull request
Jan 22, 2021
This v1.3.2 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
r-czajkowski
added a commit
to keep-network/tbtc-dapp
that referenced
this pull request
Jan 22, 2021
This v1.3.2 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
r-czajkowski
added a commit
to threshold-network/keep-core
that referenced
this pull request
Jan 25, 2021
This v1.3.3 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
r-czajkowski
added a commit
to keep-network/tbtc-dapp
that referenced
this pull request
Jan 25, 2021
This v1.3.3 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
michalsmiarowski
added a commit
to threshold-network/keep-core
that referenced
this pull request
Jan 27, 2021
…bscription Bump web3 dependency to v1.3.3 This v1.3.3 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
r-czajkowski
added a commit
to keep-network/tbtc-dapp
that referenced
this pull request
May 12, 2021
This v1.3.3 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
r-czajkowski
added a commit
to keep-network/tbtc-dapp
that referenced
this pull request
May 12, 2021
Bump web3 dependencies to the latest version v1.3.5 to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3651
Implements subscription support per EIP-1193.
Should be tested manually by maintainers with current MetaMask (^9.0.0) on Firefox.