Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@spacesailor24
Copy link
Contributor

Fixes #3907

@coveralls
Copy link

coveralls commented Feb 9, 2021

Pull Request Test Coverage Report for Build 552354768

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 226 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.5%) to 76.273%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 8 82.27%
packages/web3-utils/src/utils.js 27 10.74%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.92%
packages/web3-utils/src/index.js 42 32.12%
packages/web3-eth-accounts/src/index.js 85 33.06%
Totals Coverage Status
Change from base Build 538231133: 2.5%
Covered Lines: 3172
Relevant Lines: 3944

💛 - Coveralls

Copy link

@koraykoska koraykoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally something which should be fixed in terms of best practices. We should even think about deprecating it. I just tested it and the examples are correct.

@spacesailor24 spacesailor24 merged commit f196996 into 1.x Feb 10, 2021
@spacesailor24 spacesailor24 deleted the wyatt/3907-sha3-docs branch February 10, 2021 15:24
This was referenced Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docs for soliditySha3 to include security risk warning

4 participants