This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
EIP1559 #4155
Merged
Merged
EIP1559 #4155
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
ec47e41
npm run build for 1.4.0-rc.0
spacesailor24 d50f17a
v1.4.0-rc.0
spacesailor24 87738b7
Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth
spacesailor24 059be6d
Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth
spacesailor24 7b2acdf
Fix typo
spacesailor24 bc8a427
Fix merge conflict
spacesailor24 5c11080
WIP
spacesailor24 c53a87e
Merge branch '1.x' into wyatt/eip1559
spacesailor24 f963659
Fix type in error catch
spacesailor24 3e4fcbe
Remove commented code
spacesailor24 7681019
Update index for tx pricing info
spacesailor24 3212c05
Correct order of if statements to properly assign tx type
spacesailor24 43a755f
Update maxFeePerGas calculation
spacesailor24 51f030e
Init _handleTxType function
spacesailor24 3b3efb2
Update _handleTxPricing to use gasPrice for eip-1559 txs
spacesailor24 b458b63
Fix bugs in _handleTxPricing
spacesailor24 1b66314
Update tests for eip-1559 changes
spacesailor24 ad5a22e
Fix BN bug: .mul only accepts BN instances
spacesailor24 4ebd78a
eth.accounts.signTransaction: Add London tests
spacesailor24 cd490a8
Fix merge conflicts
spacesailor24 43fc7aa
Add EIP-1559 test without AccessList
spacesailor24 5c5a517
Add tx.common.hardfork check to _handleTxType
spacesailor24 34e5cf6
Bug fixes
spacesailor24 72c9898
Add additional undefined check in _handleTxType
spacesailor24 073be03
Add additional check for tx.hardfork in _handleTxType
spacesailor24 1e3d662
Add additional check for tx.hardfork in _handleTxType
spacesailor24 2bb8c63
Update CHANGELOG
spacesailor24 572e416
Handling EIP1559 transactions in outputTransactionFormatter (#4167)
corymsmith abbc390
Revert geth docker version tag
spacesailor24 ef39538
Add additional EIP-2930 and EIP-1559 tests
spacesailor24 494f260
Merge branch '1.x' into wyatt/eip1559
spacesailor24 2437073
Merge branch 'wyatt/eip1559' of github.com:ChainSafe/web3.js into wya…
spacesailor24 b3ab709
EIP 1559 Debug #2 (#4171)
spacesailor24 dc810b3
Mergin conflicts
spacesailor24 e7d3833
Update error message
spacesailor24 d9c509a
Update error message
spacesailor24 2a90980
Merge branch 'wyatt/eip1559' of github.com:ChainSafe/web3.js into wya…
spacesailor24 7324eec
Update use of tx.type
spacesailor24 d4f1363
Replace hardfork strings with enum
spacesailor24 f2ca0d8
Type check refactors for _handleTxPricing
spacesailor24 e0e19f7
Resolve tx.gasPrice if set and tx.type < 0x2 in _handleTxPricing
spacesailor24 c5be542
Fix _handleTxType logic
spacesailor24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
WIP
- Loading branch information
commit 5c11080734ccc7582eb70cd159673e4b123e2147
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a new method?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorta, this package doesn't make use of the RPC wrappers found in
web3-eth, instead needed methods are redefined in the package. I added this method to be able to get a block to find thebaseFeePerGasThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean we can't leverage the getBlock (also refs blockCall) because it's defined in the
web3-ethpackage and not accessible fromweb3-eth-accounts?In this case don't we have a dependency or at least a DRY issue that could be addressed somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreMiras Yes, and we plan to address the problematic architecture in
4.x(our rewrite), so for now it's just about making the least amount of change to1.xas possible, to refrain from introducing additional bugs