Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

EIP 1559 Debug #2 #4171

Merged
spacesailor24 merged 18 commits into from
Jul 19, 2021
Merged

EIP 1559 Debug #2 #4171

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ef39538
Add additional EIP-2930 and EIP-1559 tests
spacesailor24 Jul 8, 2021
2437073
Merge branch 'wyatt/eip1559' of github.com:ChainSafe/web3.js into wya…
spacesailor24 Jul 10, 2021
6bd70cd
Update gasPrice to geth default minimum
spacesailor24 Jul 10, 2021
53190c3
Merge branch 'wyatt/eip1559' into wyatt/eip1559-debug-2
spacesailor24 Jul 10, 2021
2a85305
Replace hex number with number string
spacesailor24 Jul 14, 2021
44effca
Add test skip if using Ganache
spacesailor24 Jul 14, 2021
e7c14d1
Add done function to ganache skip
spacesailor24 Jul 14, 2021
83a7fd8
Add done function to ganache skip
spacesailor24 Jul 14, 2021
a1b6833
Update gasPrice params
spacesailor24 Jul 14, 2021
dd8c835
Bump gasPrice to Geth default
spacesailor24 Jul 14, 2021
8e82988
Bump docker geth version to stable
spacesailor24 Jul 14, 2021
9d0aa3e
Gas price type number for 1 Gwei
Jul 16, 2021
2015ad4
gasPrice type and backfills timeout change
Jul 16, 2021
45ab40c
gasPrice type and test acct creation
Jul 16, 2021
13f3b7b
added nonce for geth auto nonce issue, removed auto acct creation
jdevcs Jul 19, 2021
3cc1754
Remove redundant London test. Add gasLimit field to London test
spacesailor24 Jul 19, 2021
2c86b67
Add validation for tx.maxPriorityFeePerGas and tx.maxFeePerGas
spacesailor24 Jul 19, 2021
3661734
Add additional 1559 tests
spacesailor24 Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add done function to ganache skip
  • Loading branch information
@spacesailor24
spacesailor24 committed Jul 14, 2021
commit 83a7fd81d6c0585ca383fc4becb13cffc567b45c
16 changes: 8 additions & 8 deletions test/e2e.method.signing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ describe('transaction and message signing [ @E2E ]', function() {
assert(receipt.status === true);
});

it('accounts.signTransaction, (with callback, nonce not specified)', function(donedone){
it('accounts.signTransaction, (with callback, nonce not specified)', function(done){
// ganache does not support eth_signTransaction
if (process.env.GANACHE || global.window ) {
done();
Expand All @@ -150,7 +150,7 @@ describe('transaction and message signing [ @E2E ]', function() {
});
});

it('accounts.signTransaction, (EIP-2930, accessList specified)', function(donedone){
it('accounts.signTransaction, (EIP-2930, accessList specified)', function(done){
// ganache does not support eth_signTransaction
if (process.env.GANACHE || global.window ) {
done();
Expand All @@ -174,7 +174,7 @@ describe('transaction and message signing [ @E2E ]', function() {
});
});

it('accounts.signTransaction, (EIP-2930, type 1 specified)', function(donedone){
it('accounts.signTransaction, (EIP-2930, type 1 specified)', function(done){
// ganache does not support eth_signTransaction
if (process.env.GANACHE || global.window ) {
done();
Expand All @@ -198,7 +198,7 @@ describe('transaction and message signing [ @E2E ]', function() {
});
});

it('accounts.signTransaction, (EIP-1559, maxFeePerGas and maxPriorityFeePerGas specified)', function(donedone){
it('accounts.signTransaction, (EIP-1559, maxFeePerGas and maxPriorityFeePerGas specified)', function(done){
// ganache does not support eth_signTransaction
if (process.env.GANACHE || global.window ) {
done();
Expand All @@ -223,7 +223,7 @@ describe('transaction and message signing [ @E2E ]', function() {
});
});

it('accounts.signTransaction, (EIP-1559, type 2 specified)', function(donedone){
it('accounts.signTransaction, (EIP-1559, type 2 specified)', function(done){
// ganache does not support eth_signTransaction
if (process.env.GANACHE || global.window ) {
done();
Expand All @@ -247,7 +247,7 @@ describe('transaction and message signing [ @E2E ]', function() {
});
});

it('accounts.signTransaction, (EIP-1559, maxFeePerGas and accessList specified)', function(donedone){
it('accounts.signTransaction, (EIP-1559, maxFeePerGas and accessList specified)', function(done){
// ganache does not support eth_signTransaction
if (process.env.GANACHE || global.window ) {
done();
Expand Down Expand Up @@ -554,9 +554,9 @@ describe('transaction and message signing [ @E2E ]', function() {

const recovered = await web3.eth.personal.ecRecover(message, signature);
assert.equal(accounts[1].toLowerCase(), recovered.toLowerCase());
})done;
});

it('eth.accounts.sign', async function(){
it('eth.accounts.sign', async function(done){
if (process.env.GANACHE || global.window ) {
done();
return
Expand Down