Photo link remains displayed in “Give more details” text area when removing the uploaded image

[softvision-oana-arbuzov]

Browser / Version: Firefox 53.0.3 Release (Desktop), Chrome 58.0.3029.110 (Desktop), Firefox Nightly 55.0a1 (2017-05-31) (Mobile)
Operating System: Windows 10 Pro, Android 6.0.1

Steps to Reproduce:

1. Navigate to: www.webcompat.com.
2. Tap “Report bug” button.
3. Type in the required information and attach a screenshot.
4. After screenshot is attached, tap “Remove image upload” button.
5. Observe behavior.

Expected Behavior:
Screenshot is removed and link no longer available in “Give more details” text area.

Actual Behavior:
Screenshot is removed, but link to the screenshot remains displayed in “Give more details” text area.

Note:

1. Submitting the issue, will display all uploaded photos, regardless they were previously removed.

Watchers:
@softvision-sergiulogigan
@softvision-oana-arbuzov

Notes:

1. Screenshot attached.

sv;

[miketaylr]

Yeah, this is a regression. Possibly a bug in the regex here:

https://github.com/webcompat/webcompat.com/blob/master/webcompat/static/js/lib/bugform.js#L416-L437

[karlcow]

Rha… my bad then.
And it means we are missing a test for it. if we didn't detect it.

[karlcow]

Yeah. My bad. Confirmed. 0d20e11

This one is working.
\[!\[[^\]]+\]\([^\)]+\)\]\([^\)]+\)$

[zoepage]

Thanks @karlcow :)

I'm sure, @cch5ng will be happy to add that test. (Also happy to help and walk you through.)

[cch5ng]

hi, what should I do to simulate the fixed version? do I wait for a PR from @karlcow and then make a separate PR for the added test? thanks. (or am I expected to check in changes for both?)

[karlcow]

@cch5ng as you wish. If you want to fix and add the test, I'm fine too.
Or if you prefer me to do the PR request for the regex, I can do it too.
Just tell me.

[cch5ng]

@karlcow thanks, I can do both then (update regex and add a test).