Fixes #1030. More robust handling for UA parsing methods.#1032
Merged
Fixes #1030. More robust handling for UA parsing methods.#1032
Conversation
added 3 commits
April 29, 2016 17:31
Give it a None default arg, in case it ever gets called without an arg. Always return "unknown" by default. If we get weird results back (i.e., "other"), normalize to "unknown".
added 3 commits
April 29, 2016 17:56
Default None arg. Return "Unknown" by default. Normalize "Other" to "Unknown" Add tests.
Default None arg. Return "Unknown" by default. Switch position of "(Tablet)" modifier to come before the version string. Normalize "Other" result to "Unknown" for weird values.
miketaylr
force-pushed
the
issues/1030/1
branch
from
e4872e0 to
d066fc6
Compare
tests/test_helpers.py
Outdated
| self.assertEqual(get_browser(None), 'Unknown') | ||
|
|
||
| def test_get_browser(self): | ||
| '''Test Browser parsing for non-tablet devices.''' |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tests/test_helpers.py
Outdated
| PARSED_NON_TABLET_BROWSER = "Firefox Mobile 40.0" | ||
| PARSED_TABLET_BROWSER = "Firefox Mobile 41.0 (Tablet)" | ||
| FIREFOX_UA = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0' # nopep8 | ||
| FIREFOX_MOBILE_UA = 'Mozilla/5.0 (Android; Mobile; rv:40.0) Gecko/40.0 Firefox/40.0' # nopep8 |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Member
Author
|
Thanks for reviewing! I'll push some follow up commits this afternoon or evening. |
Member
Author
Member
|
r+ Yeah 🎇 |
Member
Author
|
Thanks Karl! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote the following methods to be more paranoid about input before passing it to ua-parser:
get_browser
get_os
get_browser_name
And added a bunch of tests.
r? @karlcow