Fixes #1079 - added functional tests for URL and search box update up…#1080
Merged
Fixes #1079 - added functional tests for URL and search box update up…#1080
Conversation
tests/functional/search-non-auth.js
Outdated
| }, | ||
|
|
||
| 'Clicking on label search adds query parameter to the URL': function() { | ||
| var params = '?q=dfjdkfjdkfjkdfjdkjf'; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Member
|
r+ with the one small nit addressed. |
…on label click in /issues
deepthivenkat
force-pushed
the
Issue/1079/1
branch
from
9cdc979 to
cbe8624
Compare
Member
|
nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on label click in /issues
r? @miketaylr
The first test checks the URL update using .getCurrentUrl.
The second test checks the search box update by getting value of search box using Id selector