Fixes #975 - Replace new with needstriage#1114
Merged
miketaylr merged 2 commits intowebcompat:masterfrom Jul 6, 2016
Merged
Conversation
Member
Author
|
Opened Issue #1115 |
| # For paginated results on the /issues page, see /issues/search/new. | ||
| # Note that 'needstriage' here is primarily used on the homepage. | ||
| # For paginated results on the /issues page, | ||
| # see /issues/search/needstriage. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
deepthivenkat
force-pushed
the
issues/975/1
branch
from
8be2cef to
3b756df
Compare
deepthivenkat
force-pushed
the
issues/975/1
branch
from
3b756df to
333d183
Compare
Member
Author
|
All the tests passed in my local machine. Whereas most tests failed in Travis.
|
Member
Yeah, that's because your PR is from a fork which means Travis doesn't give it access to secret env variables. Thanks for showing that tests pass for you locally! |
Member
|
r+, looks good! |
Member
|
This is kind of weird, Travis is failing tons of tests -- but locally it's OK for me: https://travis-ci.org/webcompat/webcompat.com/builds/142773957 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new pull request for all the previous commits in #975 from my local fork.
The functional test "Issue-list - Loading URL with stage param loads issues" passed in my local machine.
Raised a separate issue because this fails in Travis.
All other functional test cases passed successfully.