Skip to content

Fixes #1120 - Add status code 301 and redirect url for /issues/catego… #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miketaylr merged 2 commits into from
Jul 14, 2016
Merged

Fixes #1120 - Add status code 301 and redirect url for /issues/catego… #1130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c9a63
Issue #1120 - Add status code 301 and redirect url for /issues/catego…
deepthivenkat Jul 9, 2016
5dd4e21
Issue #1120 - Added return statement for 'new' issue category and pre…
deepthivenkat Jul 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions webcompat/api/endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@
from flask import abort
from flask import Blueprint
from flask import g
from flask import redirect
from flask import request
from flask import session
from flask import url_for

from webcompat import app
from webcompat import limiter
Expand Down Expand Up @@ -128,7 +130,8 @@ def get_issue_category(issue_category):
# For paginated results on the /issues page,
# see /issues/search/needstriage.
elif issue_category == 'new':
abort(301)
return redirect(url_for('api.get_issue_category',
issue_category='needstriage'), 301)

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

else:
# The path doesn’t exist. 404 Not Found.
abort(404)
Expand Down Expand Up @@ -189,7 +192,8 @@ def get_category_from_search(issue_category):
query_string += ' state:closed '
return get_search_results(query_string, params)
elif issue_category == 'new':
abort(301)
return redirect(url_for('api.get_category_from_search',
issue_category='needstriage'), 301)
else:
# no known keyword we send not found
abort(404)
Expand Down