Fixes #1317 - install packages in virtualenv

[zoepage]

The issue #1317 was caused by non-installed packages in the virtualenv.
It seems it's not clearly described for a new contributor in the contribute.md and as we have the scripts anyway, it should be added to the npm run virtualenv. The install will be skipped when the packages are found.

@miketaylr @karlcow could you please confirm? Thanks :)

[miketaylr]

Hmm, I'm gonna try to repro #1317, then come back to this.

[miketaylr]

So, I can repro #1317. I think there's something wrong with npm run virtualenv -- it installs everything, but fails to activate the virtualenv.

I wonder why...

[karlcow]

is there any reasons why some of us are using npm run for things which are just python related. Asking because I might miss something.

fwiw my process is always:

workon webcompatcom #this activates the virtualenv through virtualenvwrapper, but it's the same as just doing virtualenv mostly
# git stuff
# edit
# more git stuff
grunt # only if I touched the JS/CSS
python run.py

[miketaylr]

is there any reasons why some of us are npm run for things which are just python related. Asking because I might miss something.

It's a good question. I think the idea was to have an "EZ setup", or a single command to do all the dirty work. In theory npm scripts are just running bash scripts, so it's like a diet Makefile.

My workflow is exactly the same as @karlcow's, FWIW. But I only run grunt if I change branches (and suspect style changed) or touch CSS (I have eslint integrated into sublime, so I skip the grunt eslint task).

[magsout]

@karlcow The only reason is to abstract the commands for the installation of the project. We don't care how many recipes we have for python, js tools etc...

One ring (recipes) to rule them all ? 😜

[miketaylr]

LGTM, thanks @zoepage!