Fixes #1369: Add docstring to describe tests #1397
Conversation
|
@jeanhl I guess you are referring to #1369 first of all, Thanks! There are a couple of things to fit in the convention of this project. See the format of the contribution done on #1392 and interactions with @miketaylr
|
|
@jeanhl thanks for the pull request. so to be really in harmony with the CONTRIBUTING guidelines, you need to change the commit message. Usually we do:
I will review your commit. |
karlcow
left a comment
There was a problem hiding this comment.
If you are not comfortable with rebasing. I'll do it.
| class TestForm(unittest.TestCase): | ||
|
|
||
| def test_normalize_url(self): | ||
| ''' Make sure that normalize_url method works.''' |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Thank you! These are very helpful feedback. I'll revise the docstrings and do a new commit tomorrow morning. :) |
|
I made the changes and committed them |
|
Thanks a lot @jeanhl I will rebase it to have a cleaner commit. |
|
Thanks Karl! 😃 |
I added docs to the unittests.
Edit:
r? @karlcow
Sorry for the mess and thanks for being so patient with me