Fixes #1449 Changed GA to alternative async tracking snippet#1467
Fixes #1449 Changed GA to alternative async tracking snippet#1467miketaylr merged 1 commit intowebcompat:masterfrom
Conversation
nj4710
changed the title
webcompat/templates/layout.html
Outdated
| })(window,document,'script','//www.google-analytics.com/analytics.js','ga'); | ||
| ga('create', 'UA-49507820-1', 'webcompat.com'); | ||
| ga('send', 'pageview'); | ||
| window.ga=window.ga||function(){(ga.q=ga.q||[]).push(arguments)};ga.l=+new Date; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
(This is related to scarier part of #1450) |
|
I have moved the file to a new script but the purpose of having this script is unclear to me. Why exactly are we using this script ? @miketaylr |
Eventually we want to remove all inline script instances, for security purposes. See #763 and related issues to learn a bit more. |
webcompat/static/js/vendor/ga.js
Outdated
| window.ga=window.ga||function(){(ga.q=ga.q||[]).push(arguments)};ga.l=+new Date; | ||
| ga('create', 'UA-49507820-1', 'webcompat.com'); | ||
| ga('send', 'pageview'); | ||
| console.log("executed"); No newline at end of file |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Thank you @nj4710! |
2 participants
I have changed the value of property-id ( taken from the old snippet). Are there anymore variables that needs to be changed? r? @miketaylr