Skip to content

Fix #1228 - Improves webhooks to send labels at once #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miketaylr merged 9 commits into from
May 24, 2017
Merged

Fix #1228 - Improves webhooks to send labels at once #1566

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c6b2bb0
Issue #1228 - Adds test files for webhook events
karlcow May 19, 2017
cc2a869
Issue #1228 - Removes labeler test from test_url
karlcow May 19, 2017
3ff3e04
Issue #1228 - Adds LOCALHOST key for Webhooks
karlcow May 19, 2017
5f9294c
Issue #1228 - Removes dump to DB feature
karlcow May 19, 2017
c49ef3e
Issue #1228 - Changes signature computation in 2 functions
karlcow May 19, 2017
c6c7980
Issue #1228 - Adds tests for webhooks
karlcow May 19, 2017
0fea5eb
Issue #1228 - Makes labeler route slimmer
karlcow May 19, 2017
5f5b6e9
Issue #1228 - Removes unused header
karlcow May 24, 2017
39874cb
Issue #1228 - Uses proxy_request instead of local request
karlcow May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Issue #1228 - Removes dump to DB feature 
We might want to do that in the future but for now, it is basically
unused code.
  • Loading branch information
@karlcow
karlcow committed May 19, 2017
commit 5f9294c3032f21842f417bd6594c23c95eb42f2a
2 changes: 0 additions & 2 deletions webcompat/webhooks/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from flask import Blueprint
from flask import request

from helpers import dump_to_db
from helpers import parse_and_set_label
from helpers import set_label
from helpers import signature_check
Expand Down Expand Up @@ -52,7 +51,6 @@ def hooklistener():
# Setting "Needs Triage" label by default
# to all the new issues raised
set_label('status-needstriage', issue_number)
dump_to_db(issue_title, issue_body, issue_number)
return ('gracias, amigo.', 200)
else:
return ('cool story, bro.', 200)
Expand Down
6 changes: 0 additions & 6 deletions webcompat/webhooks/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
import requests

from webcompat import app
from webcompat.db import issue_db
from webcompat.db import WCIssue
from webcompat.helpers import extract_url


def api_post(endpoint, payload, issue):
Expand Down Expand Up @@ -52,9 +49,6 @@ def set_label(label, issue_number):


def dump_to_db(title, body, issue_number):
url = extract_url(body)
issue_db.add(WCIssue(issue_number, title, url, body))
issue_db.commit()


def compare_digest(x, y):
Expand Down