Fixes #1627 - Adds coco.fr to the abuse list#1628
Conversation
|
@karlcow sorry for the delay, I will look at this today |
There was a problem hiding this comment.
(updated) LGTM in python. seems like a bunch of travis tests are failing though. is that important? after addressing the travis issues, this could be merged.
it will take me additional time to go through the views.py code in detail to ask questions. but it seems I could do so even after the PR gets closed.
|
@cch5ng it's good you took time. The storm seems to have passed. I will close the pull request and we can reopen it, in case this is coming back. Thanks a lot. |
|
@karlcow this is the start to my questions about views.py (for /issues/new route) but eventually I'll cover the entire views.py. I might include some questions I had when trying to address a different issue later. for https://github.com/webcompat/webcompat.com/blob/master/webcompat/views.py#L179 https://github.com/webcompat/webcompat.com/blob/master/config/__init__.py#L49 for the homepage view (/), I'm trying to understand the flow for how the triage issues list gets generated. in the source it seems to be coming from a backbone model but I'm not clear where in the code the request to the github api gets made. could I get a pointer to which source files I should be looking at? in the future is it OK for me to include both you and MikeT as JS reviewers? I know both of you are very busy but your review concerns are a bit different and I think I learn from both forms. |
r? @cch5ng
We had abuse on the project for the domain coco.fr.